feat: add cluster addons support #893
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Charles-Edouard Brétéché <[email protected]>
Signed-off-by: Charles-Edouard Brétéché <[email protected]>
Signed-off-by: Charles-Edouard Brétéché <[email protected]>
ddelange
reviewed
Jan 23, 2023
Comment on lines
+7
to
+9
| cluster_addons = [ | ||
| file("${path.module}/kubescheduler.yaml") | ||
| ] |
There was a problem hiding this comment.
Did you try it out ?
I'm concerned with this change showing perpetual diff.
There was a problem hiding this comment.
no I didn't try it -- the file content should be included in the hash though right? or why do you think it would result in a perpetual diff?
There was a problem hiding this comment.
because i'm not reading cluster addons back.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds cluster addons support.
Fixes #874