Merge pull request #88 from eddex/fix/calculating_credits_by_semester…

…_correctly Fix calculating the semster credits
eddex · Oct 16, 2021 · e2ef10c · e2ef10c
2 parents 85878d9 + 5925c14
commit e2ef10c
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/src/main.js b/src/main.js
@@ -343,8 +343,10 @@ function createChart(div, modules) {
     const creditsDoneBySemesterCount = [0, 0, 0, 0, 0, 0, 0, 0, 0];
 
     // calculate how many credits were achieved for each semester
+    // Only show the modules that are passed or are from the active semester
+    const activeSemester = Math.max.apply(Math, modules.map(function(o) { return o.semester; }))
     modules.forEach(m => {
-        if (m.grade != 'F' && m.semester != undefined && m.UseInStats) {
+        if ((m.passed && m.semester != undefined && m.UseInStats) || m.semester == activeSemester) {
             creditsDoneBySemesterCount[m.semester] += Number(m.credits);
         }
     })