Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor SphericalVector interpolation method to use array::ArrayViewVariant. #227

Merged
merged 1 commit into from
Oct 14, 2024
Merged

Refactor SphericalVector interpolation method to use array::ArrayViewVariant. #227

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
84 changes: 34 additions & 50 deletions src/atlas/interpolation/method/sphericalvector/SphericalVector.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@
* which can be obtained at http://www.apache.org/licenses/LICENSE-2.0.
*/

#include <cmath>
#include <variant>

#include "atlas/interpolation/method/sphericalvector/SphericalVector.h"

#include "atlas/array/ArrayView.h"
Expand Down Expand Up @@ -203,59 +206,40 @@ template <typename MatMul>
void SphericalVector::interpolate_vector_field(const Field& sourceField,
Field& targetField,
const MatMul& matMul) {
ATLAS_ASSERT_MSG(sourceField.variables() == 2 || sourceField.variables() == 3,
"Vector field can only have 2 or 3 components.");

if (sourceField.datatype().kind() == array::DataType::KIND_REAL64) {
interpolate_vector_field<double>(sourceField, targetField, matMul);
return;
}

if (sourceField.datatype().kind() == array::DataType::KIND_REAL32) {
interpolate_vector_field<float>(sourceField, targetField, matMul);
return;
}
const auto sourceViewVariant = array::make_view_variant(sourceField);

const auto sourceViewVisitor = [&](auto sourceView) {
if constexpr (array::is_rank<2, 3>(sourceView) &&
array::is_non_const_value_type<float, double>(sourceView)) {
using SourceView = std::decay_t<decltype(sourceView)>;
using Value = typename SourceView::non_const_value_type;
constexpr auto Rank = SourceView::rank();
auto targetView = array::make_view<Value, Rank>(targetField);

switch (sourceField.variables()) {
case 2:
return matMul.apply(sourceView, targetView, twoVector);
case 3:
return matMul.apply(sourceView, targetView, threeVector);
default:
ATLAS_THROW_EXCEPTION("Error: no support for " +
std::to_string(sourceField.variables()) +
" variable vector fields.\n" +
" Number of variables must be 2 or 3.");
}

} else {
ATLAS_THROW_EXCEPTION(
"Error: no support for rank = " + std::to_string(sourceField.rank()) +
" and value type = " + sourceField.datatype().str() + ".\n" +
"Vector field must have rank 2 or 3 with value type "
"float or double");
}
};

ATLAS_NOTIMPLEMENTED;
std::visit(sourceViewVisitor, sourceViewVariant);
};

template <typename Value, typename MatMul>
void SphericalVector::interpolate_vector_field(const Field& sourceField,
Field& targetField,
const MatMul& matMul) {
if (sourceField.rank() == 2) {
interpolate_vector_field<Value, 2>(sourceField, targetField, matMul);
return;
}

if (sourceField.rank() == 3) {
interpolate_vector_field<Value, 3>(sourceField, targetField, matMul);
return;
}

ATLAS_NOTIMPLEMENTED;
}

template <typename Value, int Rank, typename MatMul>
void SphericalVector::interpolate_vector_field(const Field& sourceField,
Field& targetField,
const MatMul& matMul) {
const auto sourceView = array::make_view<Value, Rank>(sourceField);
auto targetView = array::make_view<Value, Rank>(targetField);

if (sourceField.variables() == 2) {
matMul.apply(sourceView, targetView, twoVector);
return;
}

if (sourceField.variables() == 3) {
matMul.apply(sourceView, targetView, threeVector);
return;
}

ATLAS_NOTIMPLEMENTED;
}

} // namespace method
} // namespace interpolation
} // namespace atlas
Loading