Refactor util::pack_vector_fields to use array::ArrayViewVariant
#226
+16
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 25, 2024
|
@odlomax Ready for rebase / conflict resolution |
odlomax
force-pushed
the
feature/refactor_pack_vector_fields
branch
from
ea26e71
to
96edef9
Compare
|
There we go. A bit of brute force was required to fix the branch! |
|
Blimey, I didn't see that one coming... |
rerunning to see if it is a fluke |
wdeconinck
approved these changes
Oct 14, 2024
wdeconinck
added a commit
that referenced
this pull request
Nov 18, 2024
* release/0.40.0: (40 commits) Update changelog Version 0.40.0 Add hicLaunchHostFunc for async host functions Add test for various use cases of StructuredInterpolation2D with limiter Implement StructureInterpolation2D for 3-dimensional fields with extra variables) Fix application of limiter for StructuredInterpolation2D Protect atlas_test_array_view_variant to eckit v 1.27.0 Move example-fortran inside atlas_HAVE_DOCS (#235) Fix possible device-memory leak in WrappedDataStore (fixes #234) add device data on FieldSet Add test for fieldset device operators Add fieldset device operators Update fctest_field_gpu to test acc deviceptr Update test_field_acc to test acc deviceptr Add device_data Fortran access to Field Refactored spherical vector interpolation method. (#227) Refactored (un)pack_vector_fields. (#226) Integrate `pack_vector_fields` into `SphericalVector` Interpolation method. (#224) Fixed ordering of fixup_halos and halo_exhange in StructuredColumns.cc (#223) Tidied headers and error message. (#231) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors
util::pack_vector_fieldsto usestd::variant<ArrayViews...>withstd::visit, as opposed to nestedswitchstatements to resolve the possibleValuetypes andRankvalues for different arrays.I also found it beneficial to refactor
array::make_view_variantsuch that it produces either a variant ofconstor a variant ofnon- constArrayView types.This PR needs #220 and #224 to be merged first.