Made sure cubed-sphere interpolation method always sets metadata. #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wdeconinck
reviewed
Jun 10, 2024
src/atlas/interpolation/method/cubedsphere/CubedSphereBilinear.cc
Outdated
Show resolved
Hide resolved
|
This one has a green light from me. I'll create an issue with the other tidy-up items I mentioned. |
wdeconinck
approved these changes
Jun 11, 2024
|
Thank you kindly, @wdeconinck. Would it be possible to issue a tag once this and #191 have gone in? |
|
This will be released in 0.38.0 some time this week. |
wdeconinck
added a commit
that referenced
this pull request
Jun 20, 2024
* release/0.38.0: (47 commits) Update Changelog Version 0.38.0 implement a procedure to carry out a regridding from high to low resolution (binning) (#191) Fixes opposite pole coordinates (#202) Avoid silent errors accessing Fieldset fields by ambiguous names (#210) Made sure cubed-sphere interpolation method always sets metadata. (#208) Add fortran interface for node-to-edge connectivity building (#209) Removed redundant headers. Fixed SphericalVector. Fixed StructuredInterpolation2D. Added failing tests. Update ci.yml to fix notification (#207) Add notifications to github workflows Remove float in Triag2D intersection algorithm (#203) Fixup: use C++17 uncaught_exceptions (extra s in exceptions) Disable logging of ATLAS_TRACE during stack unwinding (e.g. when exception is thrown) Add GPU offloading capability with OpenACC support to Native WrappedDataStore Add C++ OpenACC test for some sanity Refactor OpenACC support and implement for Native arrays Enable use of CUDA for Native arrays ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-on from #206.
Added a slight oversight in the last PR which, when combined with jcsda/oops #2670, breaks the lfric-jedi model interface.
The metadata itself is a bit hacky and both will be redundant soon. But for now, it's needed to keep things running.
Closes #205