Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ci.yml to fix notification #207

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

geier1993
Copy link
Contributor

There's a weird problem with gh actions...
The always() should make the notification trigger even when some dependencies listed in needs fail. However we have to pull the evaluation in the ${{ }} to make it work.

There's a weird problem with gh actions...
The `always()` should make the notification trigger even when some dependencies listed in `needs` fail. However we have to pull the evaluation in the ${{ }} to make it work.
@FussyDuck
Copy link

FussyDuck commented Jun 7, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@wdeconinck wdeconinck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @geier1993 I trust you here 🫣

@wdeconinck wdeconinck merged commit cea66aa into develop Jun 7, 2024
141 of 148 checks passed
Copy link

github-actions bot commented Jun 7, 2024

Private downstream CI failed.
Workflow name: private-downstream-ci-hpc
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/9413865300.

wdeconinck added a commit that referenced this pull request Jun 20, 2024
* release/0.38.0: (47 commits)
  Update Changelog
  Version 0.38.0
  implement a procedure to carry out a regridding from high to low resolution (binning) (#191)
  Fixes opposite pole coordinates (#202)
  Avoid silent errors accessing Fieldset fields by ambiguous names (#210)
  Made sure cubed-sphere interpolation method always sets metadata. (#208)
  Add fortran interface for node-to-edge connectivity building (#209)
  Removed redundant headers.
  Fixed SphericalVector.
  Fixed StructuredInterpolation2D.
  Added failing tests.
  Update ci.yml to fix notification (#207)
  Add notifications to github workflows
  Remove float in Triag2D intersection algorithm (#203)
  Fixup: use C++17 uncaught_exceptions (extra s in exceptions)
  Disable logging of ATLAS_TRACE during stack unwinding (e.g. when exception is thrown)
  Add GPU offloading capability with OpenACC support to Native WrappedDataStore
  Add C++ OpenACC test for some sanity
  Refactor OpenACC support and implement for Native arrays
  Enable use of CUDA for Native arrays
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants