Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add FieldSet host/device calls #188

Open
wants to merge 19 commits into
base: develop
Choose a base branch
from

Conversation

sbrdar
Copy link
Collaborator

@sbrdar sbrdar commented Apr 22, 2024

  1. add FielSet cummulative gpu operations: allocate_device, update_device ...
  2. sync_host_device to skip unused fiels

@wdeconinck
Copy link
Member

Looks great @sbrdar with some minor change requested.

@wdeconinck wdeconinck force-pushed the feature/fieldset_device_functions branch from 7b2691a to c59c90c Compare April 26, 2024 14:06
Copy link

Private downstream CI failed.
Workflow name: private downstream ci hpc
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/8849874162.

Copy link

Private downstream CI succeeded.
Workflow name: private downstream ci hpc
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/8850000224.

@DJDavies2
Copy link
Contributor

I got this compile failure:

/home/h01/david.davies/cylc-run/atlas-188/share/mo-bundle/atlas/src/atlas/util/RegisterPointerInfo.cc:18:35: error: 'string' is not a member of 'std'
18 | static std::map<const void*, std::string, std::less<>> map_pointer_name;
| ^~~~~~
/home/h01/david.davies/cylc-run/atlas-188/share/mo-bundle/atlas/src/atlas/util/RegisterPointerInfo.cc:12:1: note: 'std::string' is defined in header ''; did you forget to '#include '?
11 | #include
+++ |+#include

@wdeconinck wdeconinck force-pushed the feature/fieldset_device_functions branch from 8868832 to 0d59a3d Compare April 29, 2024 07:28
@wdeconinck wdeconinck force-pushed the feature/fieldset_device_functions branch from 0d59a3d to 590d37d Compare April 29, 2024 07:52
Copy link

Private downstream CI succeeded.
Workflow name: private downstream ci
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/8875406461.

@wdeconinck
Copy link
Member

@DJDavies2 thanks for your helpful observation. This is now fixed.

Copy link

Private downstream CI succeeded.
Workflow name: private downstream ci
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/8893304285.

Copy link

Private downstream CI succeeded.
Workflow name: private downstream ci hpc
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/8893395539.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants