Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/multiple fixes ci precommit #41

Merged
merged 12 commits into from
Sep 18, 2024

Conversation

theissenhelen
Copy link
Collaborator

fixes/updates:

  • correct downstream-ci-hpc workflow call
  • ignore pre-commit-config and readthedocs for changelog updates
  • updates pre-commit config

adds:

  • merge strategy for CHANGELOG.md
  • adds CODEOWNERS file

@codecov-commenter
Copy link

codecov-commenter commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.83%. Comparing base (af4d9dc) to head (049319a).
Report is 11 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop      #41   +/-   ##
========================================
  Coverage    99.82%   99.83%           
========================================
  Files           21       22    +1     
  Lines         1158     1213   +55     
========================================
+ Hits          1156     1211   +55     
  Misses           2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mchantry mchantry added the ATS approved Approved by ATS label Sep 17, 2024
anaprietonem
anaprietonem previously approved these changes Sep 18, 2024
Copy link

@anaprietonem anaprietonem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments regarding readability and some clarifications, but otherwise the PR LGTM!

.pre-commit-config.yaml Show resolved Hide resolved
.github/CODEOWNERS Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
Copy link

@anaprietonem anaprietonem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modifications and answers seem good to me so I am approving the PR

@JesperDramsch JesperDramsch merged commit 43846f0 into develop Sep 18, 2024
100 checks passed
@JesperDramsch
Copy link
Member

Thanks @anaprietonem

@JesperDramsch JesperDramsch deleted the chore/multiple-fixes-ci-precommit branch September 18, 2024 10:14
theissenhelen added a commit that referenced this pull request Sep 20, 2024
* fix: change pre-cmmit autoupdate schedule to monthly

* fix: change the merge strategy for Changelog to Union

* fix: add .envrc to .gitignore

* ci: ignore pre-commit-config and readthedocs for changelog updates

* ci: fix to correct hpc workflow call

* fix: update precommit config

* chore: update pre-commits

* feat: add codeowners file

* chore: update dependencies

* ci: add hpc-config

* docs: changelog

* fix: respond to review comments

---------

Co-authored-by: Jesper Dramsch <[email protected]>
theissenhelen added a commit that referenced this pull request Sep 27, 2024
* fix: change pre-cmmit autoupdate schedule to monthly

* fix: change the merge strategy for Changelog to Union

* fix: add .envrc to .gitignore

* ci: ignore pre-commit-config and readthedocs for changelog updates

* ci: fix to correct hpc workflow call

* fix: update precommit config

* chore: update pre-commits

* feat: add codeowners file

* chore: update dependencies

* ci: add hpc-config

* docs: changelog

* fix: respond to review comments

---------

Co-authored-by: Jesper Dramsch <[email protected]>
theissenhelen added a commit that referenced this pull request Oct 25, 2024
* fix: change pre-cmmit autoupdate schedule to monthly

* fix: change the merge strategy for Changelog to Union

* fix: add .envrc to .gitignore

* ci: ignore pre-commit-config and readthedocs for changelog updates

* ci: fix to correct hpc workflow call

* fix: update precommit config

* chore: update pre-commits

* feat: add codeowners file

* chore: update dependencies

* ci: add hpc-config

* docs: changelog

* fix: respond to review comments

---------

Co-authored-by: Jesper Dramsch <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ATS approved Approved by ATS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants