Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/hierarchical graphs #37

Open
wants to merge 24 commits into
base: develop
Choose a base branch
from

Conversation

icedoom888
Copy link

An implementation of hierarchical graph model.
This allows for the creation of a model capable of dealing with multi-layered hierarchical graphs.
The model is agnostic to the choosen architecture (GNN, GraphTransformer).

@FussyDuck
Copy link

FussyDuck commented Sep 11, 2024

CLA assistant check
All committers have signed the CLA.

@mchantry
Copy link
Member

@icedoom888 thanks for the contribution.
Could you rebase it on top of
https://github.com/ecmwf/anemoi-models/pull/45/files which should be merged in the next day.
to solve the instantiate issue?

@icedoom888
Copy link
Author

Hello @mchantry, @floriankrb, I am currently blocked due to the switch to anemoi-training from aifs-mono.
Will resume working on this and address your comments once my pipeline is functional again!

@icedoom888
Copy link
Author

UPDATE:

  • Full refactor of hierarchical model implementation (done w/ @JPXKQX )
  • More readable code
  • Moving to anemoi-training for model testing

Please feel free to take a look and make any sort of suggestions!

Comment on lines +1 to +9
# (C) Copyright 2024 ECMWF.
#
# This software is licensed under the terms of the Apache Licence Version 2.0
# which can be obtained at http://www.apache.org/licenses/LICENSE-2.0.
# In applying this licence, ECMWF does not waive the privileges and immunities
# granted to it by virtue of its status as an intergovernmental organisation
# nor does it submit to any jurisdiction.
#

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can the copyright statement be updated in accordance with #67?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done ✔️

src/anemoi/models/models/hierarchical.py Show resolved Hide resolved
Comment on lines 82 to 86
print(
input_dim,
getattr(self, f"latlons_{self._graph_hidden_names[0]}").shape[1],
self.hidden_dims[self._graph_hidden_names[0]],
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a leftover debug?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed ✔️

This was referenced Nov 11, 2024
@JPXKQX JPXKQX requested a review from HCookie November 26, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants