Skip to content

Commit

Permalink
Continue mirror extension versions even if one fails
Browse files Browse the repository at this point in the history
Currently, the OpenVSX server stops mirroring extension version if one of the
versions failed to be mirrored. This commit logs the mirror failure instead of
throwing an error.

Fixes #923.
  • Loading branch information
hoangphamEclipse committed Jun 13, 2024
1 parent eb6cdd6 commit 32caeb7
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -142,8 +142,8 @@ private void mirrorExtensionVersions(String namespaceName, String extensionName,
mirrorExtensionVersion(json);
data.getMirroredVersions().increment();
} catch (Throwable t) {
jobContext.logger().info("failure to mirror " + NamingUtil.toLogFormat(json) + " (" + (i+1) + "/" + toAdd.size() + ")");
data.getFailedVersions().increment();
throw t;
}
}
}
Expand Down

0 comments on commit 32caeb7

Please sign in to comment.