bugfix: moby/buildkit dockerfile plus library incompatiblity fix #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n-mat
reviewed
Jun 19, 2023
|
This PR can be closed. It was included in omnibus PR #57 |
|
This PR can be closed. It was included in omnibus PR #57 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugfix
There is a bug in https://github.com/edrevo/dockerfile-plus which makes it incompatible with newer versions of moby/buildkit. The CLI is broken in docker versions > 24.0.0
Fix
edrevo/dockerfile-plus is/was used in the runtime layers for the CLI to improve code reuse in dockerfiles. This plugin is now broken resulting in an error similar to the following:
This plugin has fallen into obscurity with no changes in >3 years. This fix removes the use of the plugin in the cli runtime context fixing the error.
This bug impacts the ADORe CLI and plotlabserver runtime contexts both of which have been fixed with this pr.
Related Issues
moby/buildkit#3562
docker/buildx#1583
edrevo/dockerfile-plus#30