Extract parts of XpectRunner singleton #344
Conversation
This change extracts parts of the singleton XpectRunner to another class, so that other implementations can set the values of the singleton. This change is required, in order to provide alternatives of XpectRunner, such as a JUnit 5 alternative, without depending on XpectRunner. Preparation for: eclipse#262
|
This is a subset of #343, the minimal set of changes we need to port our Xpect tests to JUnit 5. If the actual PR causes too much debate / overhead or there is no one to review such big changes, this smaller set of changes would also be enough for us. |
|
@tjeske , could you take a look here? Its a small change, but needed. Or maybe you can take a look @cdietrich ? |
|
@cdietrich or @meysholdt : could you please check? |
|
@iloveeclipse my capacity this month is non existing. is tobias no longer with you? |
|
@cdietrich : no idea. @tjeske : are you with us ? :-) |
|
LGTM as far as I can tell. Honestly I am not familiar with the initial architecture idea (probably no one is anymore) but it shouldn't make things worse. If this PR solves your problem I am fine with it. |
|
@trancexpress would you be willing to become a contributor? |
Yes he will :-) |
|
i cannot judge on the thread safty of the new singleton. are we fine with it? |
Do you mean |
Its as unsafe as |
|
thx @trancexpress |
This change extracts parts of the singleton XpectRunner to another class, so that other implementations can set the values of the singleton.
This change is required, in order to provide alternatives of XpectRunner, such as a JUnit 5 alternative, without depending on XpectRunner.
Preparation for: #262