refactor: downsampling test #999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The stability test above seems good. @sashacmc can you please review this? Thanks. |
sashacmc
approved these changes
May 2, 2024
| let rate_check = move |ke: KeyExpr, rate: usize| -> bool { | ||
| tracing::info!("keyexpr: {ke}, rate: {rate}"); | ||
| if ke == ke_10hz { | ||
| rate > 0 && rate <= 10 + 1 |
There was a problem hiding this comment.
Do we really still need this +1?
In the old test, this made it possible to cover fluctuations, but in theory they shouldn’t exist here?
There was a problem hiding this comment.
TBH, I don't want it as well. But we seem to need it based on the test results.
Mallets
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to make the test
It also includes
rate_checkin the future if more rigorous criteria are in demand. (Actually, a similar logic can apply to the other tests.)