Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid JSON in admin space for static plugins #988

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

JEnoch
Copy link
Member

@JEnoch JEnoch commented Apr 29, 2024

In case of a static plugin the admin space includes such a key/value (in JSON5):

{ "key": "@/peer/1cdbe046daa889a6a88c48dccb82ead0/status/plugins/dds/__path__", "value": <static>, "encoding": "application/json", "time": "None" }

This is invalid because <static> is not between quotes.

This PR fixes that.

@JEnoch JEnoch added the bug Something isn't working label Apr 29, 2024
@JEnoch JEnoch requested a review from gabrik April 29, 2024 08:49
@JEnoch JEnoch self-assigned this Apr 29, 2024
@JEnoch JEnoch enabled auto-merge (squash) April 29, 2024 08:56
@JEnoch JEnoch changed the title Fix invalid Json in admin space for static plugins Fix invalid JSON in admin space for static plugins Apr 29, 2024
@JEnoch JEnoch merged commit feaf07f into main Apr 29, 2024
20 checks passed
@JEnoch JEnoch deleted the fix_adminspace_static_plugins branch April 29, 2024 10:17
Mallets added a commit that referenced this pull request Apr 30, 2024
* fix(zenoh_runtime): disable atexit on windows (#981)

* Revert "fix(zenoh-runtime): zenoh-c DLL crash in `libc::atexit` handler (#972)"

This reverts commit 274166d.

* ci: disable atexit cleanup on Windows

* fix: Deny publishing of zenoh-ext-examples (#984)

* Fix runtime start calling (#985)

* Fix invalid JSON in admin space for static plugins (#988)

* Fix admin space: plugins __path__ was invalid JSON (#990)

* fix(test): sporadic failures of downsampling test on Windows (#995)

* fix: set the minimal sleep interval to 17ms on windows

* fixup! fix: set the minimal sleep interval to 17ms on windows

* fixup! fix: set the minimal sleep interval to 17ms on windows

* Acl fix (#993)

* ACL does not intercept messages with no key_expr

* Update DEFAULT_CONFIG.json5

---------

Co-authored-by: Yuyuan Yuan <[email protected]>
Co-authored-by: Mahmoud Mazouz <[email protected]>
Co-authored-by: Julien Enoch <[email protected]>
Co-authored-by: OlivierHecart <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants