Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Protocol changes update from main branch #920

Closed
wants to merge 45 commits into from
Closed

Protocol changes update from main branch #920

wants to merge 45 commits into from

Conversation

milyin
Copy link
Contributor

@milyin milyin commented Apr 10, 2024

No description provided.

DenisBiryukov91 and others added 30 commits March 15, 2024 13:25
@DenisBiryukov91
break memory leaks due to cyclic references
ace10ab
@DenisBiryukov91
terminate tasks to prevent corresponding memory leaks
301ab46
@DenisBiryukov91
fix infinite recursion if session.close() is called explicitly
8b81210
@DenisBiryukov91
add function to force-drop ZRUNTIME_POOL static variable
2e7c911
@DenisBiryukov91
make TaskController copyable
adb7da7
@DenisBiryukov91
make TaskController use tokio_util TaskTracker and CancellationTokens
44dfef4
@DenisBiryukov91
terminate more tasks
e12eedf
@DenisBiryukov91
clippy, fmt
15b1c92
@DenisBiryukov91
- add ci bash script to run valgrind test;
757cd48 
- add manual resource clean up to Runtime::close();
- make certain task termination a bit cleaner;
@DenisBiryukov91
-fix fmt
a1beb28
@DenisBiryukov91
-fix fmt; update valgrind-check script
f45df41
@DenisBiryukov91
clippy
04aeeed
@DenisBiryukov91
drop runtimes instead of shutdown_background
e7134e5
@DenisBiryukov91
include memory-leaks test in ci
5c672cd
@DenisBiryukov91
add sudo before valgrind install in ci
ca05313
@DenisBiryukov91
replace ZRuntime drop with shutdown_timeout to prevent infinite wait …
a94e86f 
…time, if there any active blocking tasks left
@DenisBiryukov91
docs update
918b1f8
@DenisBiryukov91
- rename spawn -> spawn_abortable, spawn_cancellable -> spawn, for mo…
1b4622f 
…re clarity;

- Some tasks now terminate in more graceful way
@DenisBiryukov91
merge
9d293a7
@YuanYuYuan
Simplify the drop of ZRUNTIME_POOL
13ae47b
@YuanYuYuan
Update the doc
93eeacf
@DenisBiryukov91
- use ZRuntime executor instead of futures::executor
9841bea 
- terminate more tasks
- make TaskController::terminate_all[_async] accept timeout duration
@DenisBiryukov91
Merge pull request #3 from YuanYuYuan/feat/memory_leaks/drop-zruntime…
f593283 
…-pool

Improve the drop of ZRUNTIME_POOL
@DenisBiryukov91
terminate scouting task
8520a24
@milyin
Merge pull request #846 from DenisBiryukov91/fix/memory_leaks
888d340 
Fix/memory leaks
@fuzzypixelz
Squash merge sync-lockfile prs, provide zenoh HEAD hash & date (#876)
12584fa 
* ci: Squash merge sync-lockfile prs, provide zenoh HEAD hash & date

* fix: Add # before pull request number

* fix: Set zenoh HEAD info in title
@DenisBiryukov91
Correct generic name IntoSelector to TryIntoSelector in Session.get (#…
9449c31 
…879)
@Mallets
Fix cargo clippy (#880)
05b9cb4
@Mallets
Review tokio runtime being used (#875)
51f4f1c 
* Review tokio runtime being used

* Fix cargo clippy
@ayhon
feat: use GitHub's markdown alerts for warnings (#883)
02d4783
YuanYuYuan and others added 15 commits April 3, 2024 10:07
@YuanYuYuan
Fix issue #887 (#888)
6799a92
@DenisBiryukov91
fix ZRuntimePool drop crash if not runtimes were initialized
44900b7
@DenisBiryukov91
clippy and fmt
f419da8
@milyin
Merge pull request #901 from DenisBiryukov91/fix/ZRuntime_drop
1f8dbe4 
fix ZRuntimePool drop crash if not all runtimes were initialized
@DenisBiryukov91
Proposal: Cancel query timeout task, once query is finalized (#881)
d818d60 
* Cancel query timeout task, once query is finalized

* Add missing cargo.lock
@Mallets
Revert "Fix issue #887 (#888)" (#905)
9485061 
This reverts commit 6799a92.
@fuzzypixelz
fix: Release workflow (#904)
2062883 
* fix: Release workflow

* fix: Remove enforce-linking-issues workflow
@fuzzypixelz
fix: Release workflow (#909)
b2ef3dd 
* fix: Add missing ghcr prefix in release workflow

* fix: Set unpublished-deps-patterns to match all zenoh crates
@gabrik
fix(913): using 2+batch.len() when increasing rx_bytes (#914)
0926dd3 
* fix(913): using 2+batch.len() when increasing rx_bytes

Signed-off-by: gabrik <[email protected]>

* chore: format

Signed-off-by: gabrik <[email protected]>

---------

Signed-off-by: gabrik <[email protected]>
@DenisBiryukov91
make session only close its runtime on drop, if it was created from c…
fff238c 
…onfig
@DenisBiryukov91
fmt
c50b680
@DenisBiryukov91
fix address"
70d7a4c
@milyin
Merge pull request #917 from DenisBiryukov91/fix/drop_sessions_with_s…
9ba3eb9 
…ame_runtime

Prevent session from closing external runtime on drop
@milyin
Merge branch 'main' into protocol_changes_update
04f1c56
@milyin
Merge branch 'protocol_changes' into protocol_changes_update
ffcdf54
@eclipse-zenoh-bot
Copy link
Contributor

@milyin If this pull request contains a bugfix or a new feature, then please consider using Closes #ISSUE-NUMBER syntax to link it to an issue.

@milyin milyin closed this Apr 10, 2024
@milyin milyin deleted the protocol_changes_update branch April 10, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@milyin @eclipse-zenoh-bot @DenisBiryukov91 @YuanYuYuan @fuzzypixelz @Mallets @ayhon @gabrik