Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sample api rework update #907

Merged
merged 3 commits into from
Apr 5, 2024
Merged

Sample api rework update #907

merged 3 commits into from
Apr 5, 2024

Conversation

Mallets
Copy link
Member

@Mallets Mallets commented Apr 5, 2024

  • Remove unnecessary use
  • Properly mark SampleBuilder as unstable
  • Add payload() and encoding() accessors to Query

@Mallets Mallets added the enhancement Existing things could work better label Apr 5, 2024
@Mallets Mallets requested a review from milyin April 5, 2024 12:51
@eclipse-zenoh-bot
Copy link
Contributor

@Mallets If this pull request contains a bugfix or a new feature, then please consider using Closes #ISSUE-NUMBER syntax to link it to an issue.

1 similar comment
@eclipse-zenoh-bot
Copy link
Contributor

@Mallets If this pull request contains a bugfix or a new feature, then please consider using Closes #ISSUE-NUMBER syntax to link it to an issue.

@milyin milyin merged commit 232177f into sample_api_rework Apr 5, 2024
11 of 13 checks passed
@milyin milyin deleted the sample_api_rework_unstable branch April 5, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milyin milyin milyin approved these changes

Assignees
No one assigned
Labels
enhancement Existing things could work better
Projects
Zenoh 1.0.0 release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Mallets @eclipse-zenoh-bot @milyin