Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RingChannel sync/async/blocking/non-blocking #903

Merged
merged 3 commits into from
Apr 11, 2024
Merged

RingChannel sync/async/blocking/non-blocking #903

merged 3 commits into from
Apr 11, 2024

Conversation

Mallets
Copy link
Member

@Mallets Mallets commented Apr 4, 2024

Improve the current RingChannel handler implementation to be sync/async/blocking/non-blocking.

@Mallets Mallets added the enhancement Existing things could work better label Apr 4, 2024
@eclipse-zenoh-bot
Copy link
Contributor

@Mallets If this pull request contains a bugfix or a new feature, then please consider using Closes #ISSUE-NUMBER syntax to link it to an issue.

1 similar comment
@eclipse-zenoh-bot
Copy link
Contributor

@Mallets If this pull request contains a bugfix or a new feature, then please consider using Closes #ISSUE-NUMBER syntax to link it to an issue.

@Mallets Mallets requested a review from milyin April 10, 2024 16:15
sashacmc
sashacmc approved these changes Apr 10, 2024
View reviewed changes
Copy link
Member

@sashacmc sashacmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, what about examples for query/reply?

@Mallets Mallets changed the base branch from protocol_changes_bad_main_merged to protocol_changes April 11, 2024 11:44
@Mallets
Copy link
Member Author

Mallets commented Apr 11, 2024

I've added a comment in both z_get and z_queryable examples. I don't think there is the need to add dedicate examples.

@Mallets Mallets merged commit d86653e into protocol_changes Apr 11, 2024
9 of 15 checks passed
@Mallets Mallets deleted the protocol_ring branch April 11, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sashacmc sashacmc sashacmc approved these changes

@milyin milyin Awaiting requested review from milyin

Assignees
No one assigned
Labels
enhancement Existing things could work better
Projects
Zenoh 1.0.0 release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Mallets @eclipse-zenoh-bot @sashacmc