Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Protocol interest #870

Merged
merged 5 commits into from
Mar 28, 2024
Merged

Protocol interest #870

merged 5 commits into from
Mar 28, 2024

Conversation

Mallets
Copy link
Member

@Mallets Mallets commented Mar 28, 2024

Add the interest id in the declare message to disambiguate wether the declaration is sent in a response of a declare interest with future == false or not.

@eclipse-zenoh-bot
Copy link
Contributor

@Mallets If this pull request contains a bugfix or a new feature, then please consider using Closes #ISSUE-NUMBER syntax to link it to an issue.

@Mallets Mallets mentioned this pull request Mar 28, 2024
Merged
@Mallets Mallets changed the base branch from protocol_changes to interests March 28, 2024 17:01
@eclipse-zenoh-bot
Copy link
Contributor

@Mallets If this pull request contains a bugfix or a new feature, then please consider using Closes #ISSUE-NUMBER syntax to link it to an issue.

@Mallets Mallets changed the base branch from interests to protocol_changes March 28, 2024 17:02
@eclipse-zenoh-bot
Copy link
Contributor

@Mallets If this pull request contains a bugfix or a new feature, then please consider using Closes #ISSUE-NUMBER syntax to link it to an issue.

fuzzypixelz
fuzzypixelz approved these changes Mar 28, 2024
View reviewed changes
commons/zenoh-protocol/src/network/declare.rs Outdated Show resolved Hide resolved
commons/zenoh-protocol/src/network/declare.rs Outdated Show resolved Hide resolved
@Mallets Mallets merged commit 1562a17 into protocol_changes Mar 28, 2024
15 checks passed
@Mallets Mallets deleted the protocol_interest branch March 28, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fuzzypixelz fuzzypixelz fuzzypixelz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Zenoh 1.0.0 release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Mallets @eclipse-zenoh-bot @fuzzypixelz