Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly specify the default features in the examples. #854

Merged
merged 1 commit into from
Mar 25, 2024
Merged

Explicitly specify the default features in the examples. #854

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ futures = { workspace = true }
git-version = { workspace = true }
json5 = { workspace = true }
log = { workspace = true }
zenoh = { workspace = true }
zenoh = { workspace = true, default-features = true }
zenoh-ext = { workspace = true }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about enabling default-features as well in zenoh-ext?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A cargo tree -f "{p} {f}" running under zenoh/examples shows

└── zenoh-ext v0.11.0-dev (/home/circle/Workings/ZettaScale/src/zenoh/zenoh-ext) default
    ├── bincode v1.3.3 
    │   └── serde v1.0.188 alloc,default,derive,serde_derive,std (*)
    ├── env_logger v0.11.2 auto-color,color,default,humantime,regex (*)
    ├── flume v0.11.0 async,default,eventual-fairness,futures-core,futures-sink,nanorand,select (*)
    ├── futures v0.3.28 alloc,async-await,default,executor,futures-executor,std (*)
    ├── log v0.4.20 kv_unstable,std,value-bag (*)
    ├── serde v1.0.188 alloc,default,derive,serde_derive,std (*)
    ├── tokio v1.36.0 bytes,default,fs,io-std,io-util,libc,macros,mio,net,num_cpus,rt,rt-multi-thread,socket2,sync,time,tokio-macros (*)
    ├── zenoh v0.11.0-dev (/home/circle/Workings/ZettaScale/src/zenoh/zenoh) auth_pubkey,auth_usrpwd,default,transport_compression,transport_multilink,transport_quic,transport_tcp,transport_tls,transport_udp,transport_unixsock-stream,transport_ws,unstable (*)
    ├── zenoh-core v0.11.0-dev (/home/circle/Workings/ZettaScale/src/zenoh/commons/zenoh-core) default,std (*)
    ├── zenoh-macros v0.11.0-dev (proc-macro) (/home/circle/Workings/ZettaScale/src/zenoh/commons/zenoh-macros)  (*)
    ├── zenoh-result v0.11.0-dev (/home/circle/Workings/ZettaScale/src/zenoh/commons/zenoh-result) default,std (*)
    ├── zenoh-runtime v0.11.0-dev (/home/circle/Workings/ZettaScale/src/zenoh/commons/zenoh-runtime)  (*)
    ├── zenoh-sync v0.11.0-dev (/home/circle/Workings/ZettaScale/src/zenoh/commons/zenoh-sync)  (*)
    └── zenoh-util v0.11.0-dev (/home/circle/Workings/ZettaScale/src/zenoh/commons/zenoh-util) default,std (*)

So I think we can omit it.


[dev-dependencies]
Expand Down