SHM subsystem: Rust #823
Merged
SHM subsystem: Rust #823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: commons/zenoh-codec/src/core/shm.rs
…generation support
- generation works
- use numeric ID instead of string ID for SHM buffer identification - this feature speeds up segment lookups and reduces wire overhead - remove unnecessary fields from SharedMemoryManager - fix clippy warnings - added comments
- support ProtocolID exchange in establish - convert buffer based on supported protocol ids
Mallets
reviewed
Apr 18, 2024
Mallets
reviewed
Apr 18, 2024
Mallets
reviewed
Apr 18, 2024
Mallets
reviewed
Apr 18, 2024
Mallets
reviewed
Apr 18, 2024
Mallets
reviewed
Apr 18, 2024
Mallets
reviewed
Apr 18, 2024
Mallets
reviewed
Apr 18, 2024
Mallets
reviewed
Apr 18, 2024
Mallets
reviewed
Apr 18, 2024
Mallets
reviewed
Apr 18, 2024
| array: ArrayInSHM<AuthSegmentID, AuthChallenge, usize>, | ||
| } | ||
|
|
||
| impl AuthSegment { |
There was a problem hiding this comment.
With the current SHM system there is some leaking due to the shm segment never be closed.
How this new system will clean up all AuthSegment?
There was a problem hiding this comment.
AuthSegment, as any other zenoh SHM component, uses posix_shm::array::ArrayInSHM for managing shared memory. Previous SHM system used posix segment mapping on the filesystem - this mechanism required to manually delete SHM-mapped files to free shared memory and was unacceptable because our process might crash with no way to delete mapped files. The new SHM system uses system handles that are automatically unlinked when last linked process terminates, avoiding memory leakage.
Mallets
reviewed
Apr 18, 2024
|
@Mallets I resolved discussions where I made fixes |
Mallets
reviewed
Apr 18, 2024
Mallets
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #685
Closes #827