Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove pull API and protocol support #821

Merged
merged 9 commits into from
Mar 19, 2024
Merged

Remove pull API and protocol support #821

merged 9 commits into from
Mar 19, 2024

Conversation

Mallets
Copy link
Member

@Mallets Mallets commented Mar 13, 2024

#782 provides a path to implement last-value kind of functionality for the pull subscriber.
While #782 is still in a draft state, a proper PR is expected to come in the near future from @evshary .
In the meanwhile, I've quickly modified the z_pull example to have the exact same behaviour (although with a slightly different API).

@eclipse-zenoh-bot
Copy link
Contributor

@Mallets If this pull request contains a bugfix or a new feature, then please consider using Closes #ISSUE-NUMBER syntax to link it to an issue.

@Mallets Mallets requested a review from OlivierHecart March 13, 2024 16:17
@Mallets Mallets added enhancement Existing things could work better breaking-change Indicates that the issue implies a breaking change (be it at compile time or at runtime) labels Mar 13, 2024
@eclipse-zenoh-bot
Copy link
Contributor

@Mallets If this pull request contains a bugfix or a new feature, then please consider using Closes #ISSUE-NUMBER syntax to link it to an issue.

1 similar comment
@eclipse-zenoh-bot
Copy link
Contributor

@Mallets If this pull request contains a bugfix or a new feature, then please consider using Closes #ISSUE-NUMBER syntax to link it to an issue.

@Mallets Mallets self-assigned this Mar 13, 2024
@Mallets Mallets mentioned this pull request Mar 14, 2024
Closed
12 tasks
@imstevenpmwork
Copy link
Contributor

@Mallets Can you link this to the relevant issue?

@milyin milyin linked an issue Mar 15, 2024 that may be closed by this pull request
Remove PullSubscriber API, replace it with a Handler implementation #809
Closed
@Mallets Mallets mentioned this pull request Mar 18, 2024
Merged
OlivierHecart
OlivierHecart reviewed Mar 18, 2024
View reviewed changes
examples/examples/z_pull.rs Outdated Show resolved Hide resolved
zenoh/src/net/routing/hat/client/pubsub.rs Outdated Show resolved Hide resolved
zenoh/src/net/routing/hat/linkstate_peer/pubsub.rs Outdated Show resolved Hide resolved
zenoh/src/net/routing/hat/p2p_peer/pubsub.rs Outdated Show resolved Hide resolved
zenoh/src/net/routing/hat/router/pubsub.rs Outdated Show resolved Hide resolved
zenoh/src/subscriber.rs Outdated Show resolved Hide resolved
@Mallets Mallets merged commit 7300f4c into protocol_changes Mar 19, 2024
15 checks passed
@Mallets Mallets deleted the protocol_pull branch March 19, 2024 13:35
@milyin milyin mentioned this pull request Apr 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OlivierHecart OlivierHecart OlivierHecart left review comments

Assignees

@Mallets Mallets

Labels
breaking-change Indicates that the issue implies a breaking change (be it at compile time or at runtime) enhancement Existing things could work better
Projects
Zenoh 1.0.0 release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove PullSubscriber API, replace it with a Handler implementation
4 participants
@Mallets @eclipse-zenoh-bot @imstevenpmwork @OlivierHecart