Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename IntoCallbackReceiver trait to IntoHandler trait #816

Merged
merged 3 commits into from
Mar 18, 2024
Merged

Rename IntoCallbackReceiver trait to IntoHandler trait #816

merged 3 commits into from
Mar 18, 2024

Conversation

Mallets
Copy link
Member

@Mallets Mallets commented Mar 13, 2024 •
edited
Loading

Rename IntoCallbackReceiver to a more meaningful IntoHandler name.

@Mallets Mallets requested a review from p-avital March 13, 2024 09:38
@eclipse-zenoh-bot
Copy link
Contributor

@Mallets If this pull request contains a bugfix or a new feature, then please consider using Closes #ISSUE-NUMBER syntax to link it to an issue.

1 similar comment
@eclipse-zenoh-bot
Copy link
Contributor

@Mallets If this pull request contains a bugfix or a new feature, then please consider using Closes #ISSUE-NUMBER syntax to link it to an issue.

@Mallets Mallets changed the base branch from main to protocol_changes March 13, 2024 14:56
@eclipse-zenoh-bot
Copy link
Contributor

@Mallets If this pull request contains a bugfix or a new feature, then please consider using Closes #ISSUE-NUMBER syntax to link it to an issue.

@Mallets Mallets added enhancement Existing things could work better breaking-change Indicates that the issue implies a breaking change (be it at compile time or at runtime) labels Mar 13, 2024
@Mallets Mallets self-assigned this Mar 13, 2024
@eclipse-zenoh-bot
Copy link
Contributor

@Mallets If this pull request contains a bugfix or a new feature, then please consider using Closes #ISSUE-NUMBER syntax to link it to an issue.

1 similar comment
@eclipse-zenoh-bot
Copy link
Contributor

@Mallets If this pull request contains a bugfix or a new feature, then please consider using Closes #ISSUE-NUMBER syntax to link it to an issue.

@Mallets Mallets requested a review from milyin March 15, 2024 17:22
@Mallets
Copy link
Member Author

Mallets commented Mar 18, 2024

@sashacmc can you help in reviewing this PR?

@Mallets Mallets merged commit 1d1d4ed into protocol_changes Mar 18, 2024
15 checks passed
@fsteff fsteff mentioned this pull request May 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sashacmc sashacmc sashacmc approved these changes

@p-avital p-avital Awaiting requested review from p-avital

@milyin milyin Awaiting requested review from milyin

Assignees

@Mallets Mallets

Labels
breaking-change Indicates that the issue implies a breaking change (be it at compile time or at runtime) enhancement Existing things could work better
Projects
Zenoh 1.0.0 release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Mallets @eclipse-zenoh-bot @sashacmc