Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Links refactoring #748

Merged
merged 6 commits into from
Feb 23, 2024
Merged

Links refactoring #748

merged 6 commits into from
Feb 23, 2024

Conversation

sashacmc
Copy link
Member

@sashacmc sashacmc commented Feb 21, 2024 •
edited
Loading

  • Move IP (TCP, USP, TLS, QUIC) listeners functionality to commons
  • Move get_ip_interface_names to commons

@eclipse-zenoh-bot
Copy link
Contributor

@sashacmc If this pull request contains a bugfix or a new feature, then please consider using Closes #ISSUE-NUMBER syntax to link it to an issue.

@eclipse-zenoh-bot
Copy link
Contributor

@sashacmc If this pull request contains a bugfix or a new feature, then please consider using Closes #ISSUE-NUMBER syntax to link it to an issue.

@Mallets Mallets linked an issue Feb 22, 2024 that may be closed by this pull request
Add possibility to restrict a data to the interface #742
Closed
@sashacmc sashacmc marked this pull request as ready for review February 22, 2024 15:20
yellowhatter
yellowhatter approved these changes Feb 23, 2024
View reviewed changes
Copy link
Contributor

@yellowhatter yellowhatter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good

@Mallets Mallets merged commit 42f9384 into eclipse-zenoh:main Feb 23, 2024
7 of 9 checks passed
@sashacmc sashacmc deleted the ip-links-refactoring branch February 23, 2024 13:29
@sashacmc sashacmc changed the title links refactoring Links refactoring Feb 23, 2024
jerry73204 pushed a commit to NEWSLabNTU/zenoh that referenced this pull request Mar 6, 2024
@sashacmc @jerry73204
links refactoring (eclipse-zenoh#748)
c0e5e37 
* Add draft UnicastListener

* Use UnicastListener for TCP unicast, code clanup and fixes

* Use UnicastListener for UDP unicast, make linter happy

* Use UnicastListener for TLS and QUIC unicasts

* Rename UnicastListener to ListenerUnicastIP for consistency

* Move get_ip_interface_names to commons
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yellowhatter yellowhatter yellowhatter approved these changes

@Mallets Mallets Mallets approved these changes

Assignees

@sashacmc sashacmc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add possibility to restrict a data to the interface
4 participants
@sashacmc @eclipse-zenoh-bot @Mallets @yellowhatter