Encoding encoder #746
Merged
Encoding encoder #746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Closed
Mallets
added a commit
that referenced
this pull request
Mar 12, 2024
* Remove KnownEncoding enum and replace it with consts * Fix no_std * Encoding encoder (#746) * Encoding contains a mapping * Add forgotten file * Provide default encoder * Refine encoder * Fix encoding codec * Do not change the protocol representation * Accept Cow<'static, str> in EncodingMapping trait * Improve Value::Display * Fix doctests * Bump EncodingPrefix to u16. Add IANA encoding mapping. * Improve doc * Remove generic from Encoding::starts_with * Remove Display impl for Encoding * Improve doc * Improve doc * Improve encoding parsing * Improve comments * Improve doc * Encoding suffix bitflag * Encoder/Decoder traits take self * Rename encoding() to with_encoding() * Make Value, ZBuf, SingleOrVec empty() const * Derive Encoder for &mut u* and i* * Integers are encoded as le_bytes are not as string * Integers are encoded as le_bytes are not as string * Fix doctest * Refine default encoding mapping * IANA mapping starts from 1024 * Move IANA encoding to zneoh-ext * Improve docs * Improve DefaultEncoding * Add From<String> for ZBuf * Remove Value and Sample Display trait impl * Encoder/Decoder operate on ZBuf * Payload type. Put takes Into<Payload>. * Flat sample Value to Payload and Encoding fields * Add payload.rs * Polish up Publication * Add serde_cbor::Value as supported DefaultSerializer supported types * Add serde_pickle::Value as supported DefaultSerializer supported types * Add serde_yaml::Value as supported DefaultSerializer supported types * Impl TryFrom<serde_*> for Payload * Remove encoding folder * Polish up Value and Encoding * Fix doctest * Fix some erroneous prelude usage * Fix wrong typedef in publication * Encoding Id and Schema * Encoding Id and Schema * Fix encoding w_len * Wrapper type for Encoding * Add forgotten file * Expand Encoding consts and add doc * Polish doc * Polishing up Payload * Add EncodingMapping trait * Improve docs * Add deserialize in examples * Use deserialize in examples * Remove encoding from zenoh-ext * Add repr(transparent) to Payload * Improve encoding doc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes an alternative to separate the
Encodingobject from the actualMapping.