Fix matching_status_* test failures #662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mallets
reviewed
Jan 25, 2024
zenoh/tests/matching.rs
Outdated
|
|
||
| let publisher1 = ztimeout!(session1 | ||
| .declare_publisher("zenoh_matching_status_any_test") | ||
| .allowed_destination(Locality::Any) | ||
| .res_async()) | ||
| .unwrap(); | ||
| .res_async())?; |
There was a problem hiding this comment.
In case of tests it's better to use unwrap() because the error message will tell exactly at which line the test has panicked. If ? is used, it's then harder to identify which is the line that fails.
There was a problem hiding this comment.
Okay. Then I understand why we have our customized zerror since it prints more information than common errors.
Mallets
reviewed
Jan 25, 2024
| #[cfg(feature = "unstable")] | ||
| #[test] | ||
| fn zenoh_matching_status_any() { | ||
| fn zenoh_matching_status_any() -> Result<()> { |
There was a problem hiding this comment.
Based on my comment below on unwrap(), there is no need to return a Result.
Mallets
reviewed
Jan 25, 2024
zenoh/tests/matching.rs
Outdated
| }; | ||
| let config2 = zenoh::config::client([Locator::from_str(locator)?]); | ||
|
|
||
| let session1 = ztimeout!(zenoh::open(config1).res_async())?; |
|
@Mallets I've reverted the changes, can you help review this? |
YuanYuYuan
force-pushed
the
fix/matching_status_tests
branch
from
3357fef to
a1fdb49
Compare
Mallets
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we don't avoid the multicast port usage while testing. Sometimes the CI test on the main branch would fail due to the conflict of
cargo nextest run --exclude zenoh-examples --exclude zenoh-plugin-example --workspace -E 'test(=zenoh_session_multicast) | test(zenoh_matching_status)'The same error happens frequently on the tokio branch. That's why we found it. And it's better to have
Resultto verbose the failure.