Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Able to set encoding to query value #656

Closed
wants to merge 4 commits into from
Closed

Able to set encoding to query value #656

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7bc133d
Able to set encoding to query value.
evshary Jan 23, 2024
ac0ff96
Merge branch 'eclipse-zenoh:main' into support_GetBuilder_encoding
evshary Jan 29, 2024
1700074
Add empty value if there is no Value while adding encoding to query.
evshary Jan 29, 2024
b8f1926
Add some description about encoding for get in document.
evshary Jan 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions zenoh/src/query.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,6 +297,7 @@ impl<'a, 'b, Handler> GetBuilder<'a, 'b, Handler> {
}

/// Set query value.
/// The existing value and encoding will be overwritten.
#[inline]
pub fn with_value<IntoValue>(mut self, value: IntoValue) -> Self
where
Expand All @@ -306,6 +307,20 @@ impl<'a, 'b, Handler> GetBuilder<'a, 'b, Handler> {
self
}

/// Set the encoding of the existing query value.
/// The empty value will be created if value is not set.
#[inline]
pub fn encoding<IntoEncoding>(mut self, encoding: IntoEncoding) -> Self
where
IntoEncoding: Into<Encoding>,
{
match self.value {
Some(ref mut value) => value.encoding = encoding.into(),
None => self.value = Some(Value::empty().encoding(encoding.into())),
}
self
}

#[zenoh_macros::unstable]
pub fn with_attachment(mut self, attachment: Attachment) -> Self {
self.attachment = Some(attachment);
Expand Down