Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade clap to v4, refactor example arguments #616

Merged
merged 1 commit into from
Dec 7, 2023
Merged

Conversation

p-avital
Copy link
Contributor

@p-avital p-avital commented Dec 7, 2023

No description provided.

@p-avital p-avital requested a review from JEnoch December 7, 2023 10:28
@p-avital
Copy link
Contributor Author

p-avital commented Dec 7, 2023

Failed test is the flaky SHM test

@Mallets Mallets requested review from Mallets and removed request for JEnoch December 7, 2023 11:30
@Mallets
Copy link
Member

Mallets commented Dec 7, 2023

Is the goal of this PR to also move to clap 4 for zenoh-ext examples?

@p-avital
Copy link
Contributor Author

p-avital commented Dec 7, 2023

Is the goal of this PR to also move to clap 4 for zenoh-ext examples?

Everything has been updated to clap 4, but I've kept zenoh-ext and the rest bridge in the old style because the new derive based style is mainly useful in the examples where they help with code reuse. In zenoh-ext, that would require exposing that reused section in one of our public APIs.

@Mallets Mallets merged commit db235af into master Dec 7, 2023
14 of 15 checks passed
@Mallets Mallets deleted the clapdate branch December 7, 2023 14:19
@Mallets
Copy link
Member

Mallets commented Dec 7, 2023

Fix #391

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants