Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor transport trait #610

Merged
merged 24 commits into from
Dec 14, 2023
Merged

Refactor transport trait #610

merged 24 commits into from
Dec 14, 2023

Conversation

yellowhatter
Copy link
Contributor

No description provided.

@yellowhatter yellowhatter marked this pull request as ready for review December 8, 2023 17:08
@yellowhatter
Copy link
Contributor Author

Refactoring summary:

  • fixed bug with open_ack race condition
  • improved transport initialization code in unicast manager: more readable with clear on-failure cleanup (close link, close transport)
  • configuring transport object can never be accessed until it's configuration finished
  • some small fixes and optimizations here and there

@yellowhatter yellowhatter marked this pull request as draft December 11, 2023 07:07
@yellowhatter
Copy link
Contributor Author

The only uncertain thing here why I still keep this as a draft is TX executor usage in transports. I need to figure out why it doesn't work in a proper way (that's really strange). Everything other is OK and can be reviewed.

@yellowhatter
[skip ci]
0a1a82f 
- move to TransportLinkUnicastUniversal + TransportLinkUnicastUniversalInner
- remove Option for pipeline because it is not needd
@Mallets Mallets mentioned this pull request Dec 11, 2023
Closed
@yellowhatter yellowhatter marked this pull request as ready for review December 12, 2023 16:33
@yellowhatter yellowhatter marked this pull request as draft December 12, 2023 16:34
@yellowhatter
Copy link
Contributor Author

This is ready!
BTW, I noticed this: #622

@yellowhatter yellowhatter marked this pull request as ready for review December 12, 2023 16:57
@yellowhatter yellowhatter requested a review from Mallets December 13, 2023 09:31
@yellowhatter
Revert "some brush-up"
4608ce1 
This reverts commit 3137426.
@Mallets Mallets merged commit 68aadaf into eclipse-zenoh:master Dec 14, 2023
8 checks passed
@Mallets Mallets deleted the refactor_transport_trait branch December 14, 2023 14:00
@Mallets Mallets mentioned this pull request Dec 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mallets Mallets Mallets approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yellowhatter @Mallets