Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix type of __path__ in Config #609

Merged
merged 1 commit into from
Dec 6, 2023
Merged

Fix type of __path__ in Config #609

merged 1 commit into from
Dec 6, 2023

Conversation

fuzzypixelz
Copy link
Member

Mallets
Mallets requested changes Dec 5, 2023
View reviewed changes
Copy link
Member

@Mallets Mallets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor comment about using a more rusty idiom.

@fuzzypixelz fuzzypixelz requested a review from Mallets December 5, 2023 12:37
@Mallets Mallets merged commit f84138c into eclipse-zenoh:master Dec 6, 2023
8 checks passed
@fuzzypixelz fuzzypixelz deleted the fix/config-schema branch December 14, 2023 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mallets Mallets Mallets approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fuzzypixelz @Mallets