Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renaming & Dev #553

Merged
merged 6 commits into from
Sep 20, 2023
Merged

Renaming & Dev #553

merged 6 commits into from
Sep 20, 2023

Conversation

yellowhatter
Copy link
Contributor

Massive renamig:

  • transport_shm -> transport_unixpipe
  • NET transport -> Universal transport
  • SHM transport -> LowLatency transport

Dev:

  • the shm functionality and lowlatency transport are switched completely independently
  • unicast transport negotiation uses separate Extension instead of switching together with shm
  • additional tests for lowlatency transport configuration

@yellowhatter
Massive renamig:
d74f14b 
- transport_shm -> transport_unixpipe
- NET transport -> Universal transport
- SHM transport -> LowLatency transport

Dev:
- the shm functionality and lowlatency transport are switched completely independently
- unicast transport negotiation uses separate Extension instead of switching together with shm
- additional tests for lowlatency transport configuration
@yellowhatter
Fix tests and nostd checks
cc07eae
@yellowhatter
TransportManagerUnicast fails is created with incompatible config opt…
a8ab603 
…ions - qos and lowlatency
@Mallets
Copy link
Member

Mallets commented Sep 20, 2023

LGTM.

Before merging this PR, please add lowlatency parameter in https://github.com/eclipse-zenoh/zenoh/blob/master/DEFAULT_CONFIG.json5.

Mallets
Mallets requested changes Sep 20, 2023
View reviewed changes
io/zenoh-transport/src/unicast/establishment/open.rs Outdated Show resolved Hide resolved
DEFAULT_CONFIG.json5 Show resolved Hide resolved
@Mallets Mallets merged commit 0a09208 into eclipse-zenoh:master Sep 20, 2023
5 of 6 checks passed
@Mallets Mallets deleted the renaming_for_shm branch September 20, 2023 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mallets Mallets Mallets approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yellowhatter @Mallets