Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not use Linux Ephemeral ports in tests #1475

Merged

Conversation

yellowhatter
Copy link
Contributor

Sometimes this causes tests to fail because of port collision

Copy link

PR missing one of the required labels: {'enhancement', 'documentation', 'dependencies', 'bug', 'internal', 'breaking-change', 'new feature'}

@yellowhatter yellowhatter added enhancement Existing things could work better release Part of the next release labels Sep 26, 2024
@oteffahi
Copy link
Contributor

oteffahi commented Sep 26, 2024

@yellowhatter could you please also update the port numbers in these tests: https://github.com/eclipse-zenoh/zenoh/blob/main/zenoh/tests/authentication.rs#L44-L91
Please respect the unicity of ports as it is, quic and tls do not close their ports in a consistent time, and the different tests run concurrently
Thanks 😄

@yellowhatter
Copy link
Contributor Author

@yellowhatter could you please also update the port numbers in these tests: https://github.com/eclipse-zenoh/zenoh/blob/main/zenoh/tests/authentication.rs#L44-L81 Please respect the unicity of ports as it is, quic and tls do not close their ports in a consistent time, and the different tests run concurrently Thanks 😄

Yep, my text search wasn't good enough to find also these ports ;)

@yellowhatter
Copy link
Contributor Author

@oteffahi done

Copy link
Contributor

@oteffahi oteffahi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@yellowhatter yellowhatter merged commit a6c6994 into eclipse-zenoh:main Sep 26, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Existing things could work better release Part of the next release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants