Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix liveliness bugs #1450

Merged
merged 14 commits into from
Sep 19, 2024
Merged

Fix liveliness bugs #1450

merged 14 commits into from
Sep 19, 2024

Conversation

OlivierHecart
Copy link
Contributor

No description provided.

@OlivierHecart OlivierHecart added the bug Something isn't working label Sep 18, 2024
@fuzzypixelz fuzzypixelz self-requested a review September 19, 2024 13:03
@OlivierHecart OlivierHecart marked this pull request as ready for review September 19, 2024 13:22
@OlivierHecart
Copy link
Contributor Author

After zenoh-pico code review, this does not require any changes in zenoh-pico.

@OlivierHecart
Copy link
Contributor Author

@fuzzypixelz has interesting comments on how to make the code simpler.
Still this PR fixes important bugs for zenoh users. Let's merge this PR and make another one for code simplification.

@OlivierHecart OlivierHecart merged commit b3b71a7 into main Sep 19, 2024
22 of 24 checks passed
@OlivierHecart OlivierHecart deleted the bug/liveliness_fix2 branch September 19, 2024 15:04
@OlivierHecart OlivierHecart linked an issue Sep 19, 2024 that may be closed by this pull request
Duplicated liveliness token drops #1438
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fuzzypixelz fuzzypixelz Awaiting requested review from fuzzypixelz

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Duplicated liveliness token drops
1 participant
@OlivierHecart