Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more liveliness tests #1420

Merged
merged 2 commits into from
Sep 16, 2024
Merged

Add more liveliness tests #1420

merged 2 commits into from
Sep 16, 2024

Conversation

OlivierHecart
Copy link
Contributor

@OlivierHecart OlivierHecart commented Sep 16, 2024 •
edited
Loading

This is a lot of duplicated code and could be factorized, but I like it like this because:

  1. It's easier for a new comer to quickly grasp the full scenario of each test.
  2. It's easier to debug.
  3. It's easier to extract as evidences for 3rd parties.

@OlivierHecart OlivierHecart added the internal Changes not included in the changelog label Sep 16, 2024
@OlivierHecart OlivierHecart changed the title Add double liveliness subscriber tests Add more liveliness tests Sep 16, 2024
@OlivierHecart OlivierHecart marked this pull request as ready for review September 16, 2024 14:58
@Mallets Mallets merged commit 26d66ad into main Sep 16, 2024
19 of 24 checks passed
@Mallets Mallets deleted the test/liveliness branch September 16, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mallets Mallets Mallets approved these changes

@fuzzypixelz fuzzypixelz Awaiting requested review from fuzzypixelz

Assignees
No one assigned
Labels
internal Changes not included in the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OlivierHecart @Mallets