Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove Session::put onehost publisher #1412

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

wyfo
Copy link
Contributor

@wyfo wyfo commented Sep 13, 2024

This publisher caused error when it was dropped.

Copy link

PR missing one of the required labels: {'bug', 'enhancement', 'documentation', 'breaking-change', 'internal', 'new feature', 'dependencies'}

@wyfo wyfo added the bug Something isn't working label Sep 13, 2024
This publisher caused error when it was dropped.
@wyfo wyfo force-pushed the remove_oneshot_publisher branch from a5d7327 to 8adee92 Compare September 13, 2024 08:56
@wyfo
Copy link
Contributor Author

wyfo commented Sep 13, 2024

I've tested with the throughput benchmark, and I've seen no performance difference.

@Mallets Mallets merged commit aa1f703 into eclipse-zenoh:main Sep 13, 2024
13 checks passed
@OlivierHecart OlivierHecart deleted the remove_oneshot_publisher branch September 13, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants