feat!: make callback an opaque type #1405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It may allow special case for channel handlers later, in order to use async methods, or change the return type of the callback in order to support async callbacks. For the record I've tested quickly with an enum inside `Callback`, and there was a sensitive cost in performance of 1% when using callbacks.
wyfo
requested review from
Mallets,
milyin and
OlivierHecart
and removed request for
Mallets
|
PR missing one of the required labels: {'dependencies', 'bug', 'breaking-change', 'internal', 'enhancement', 'documentation', 'new feature'} |
wyfo
added
the
breaking-change
Mallets
approved these changes
Sep 12, 2024
fuzzypixelz
pushed a commit
that referenced
this pull request
Sep 23, 2024
* feat!: make callback an opaque type It may allow special case for channel handlers later, in order to use async methods, or change the return type of the callback in order to support async callbacks. For the record I've tested quickly with an enum inside `Callback`, and there was a sensitive cost in performance of 1% when using callbacks. * Retrigger CI * Retrigger CI * Retrigger CI
fuzzypixelz
pushed a commit
that referenced
this pull request
Sep 23, 2024
* feat!: make callback an opaque type It may allow special case for channel handlers later, in order to use async methods, or change the return type of the callback in order to support async callbacks. For the record I've tested quickly with an enum inside `Callback`, and there was a sensitive cost in performance of 1% when using callbacks. * Retrigger CI * Retrigger CI * Retrigger CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It may allow special case for channel handlers later, in order to use async methods, or change the return type of the callback in order to support async callbacks.
For the record I've tested quickly with an enum inside
Callback, and there was a sensitive cost in performance of 1% when using callbacks.