Bug/liveliness duplicate #1404
Merged
Bug/liveliness duplicate #1404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would it be possible to add tests to the CI to catch this bug in the future? |
fuzzypixelz
reviewed
Sep 12, 2024
fuzzypixelz
pushed a commit
that referenced
this pull request
Sep 23, 2024
* Don't resend identical declares with different ids * Clients and peers don't return local tokens from routers to avoid duplicates * User session answers LivelinessSubscribers history with locally known tokens * Session deduplicates incomming tokens
fuzzypixelz
pushed a commit
that referenced
this pull request
Sep 23, 2024
* Don't resend identical declares with different ids * Clients and peers don't return local tokens from routers to avoid duplicates * User session answers LivelinessSubscribers history with locally known tokens * Session deduplicates incomming tokens
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes several issues occurring when multiple Liveliness subs or liveliness subs and liveliness get with intersecting key expressions with or without history. The issues were mainly token duplicates or missed token undeclares.