feat(zenoh_id): exposing into [u8; 16] & to_le_bytes()
#1373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR missing one of the required labels: {'new feature', 'bug', 'dependencies', 'enhancement', 'breaking-change', 'internal', 'documentation'} |
Allowing users to create a ZenohId from a slice, using TryFrom, and also allowing users to convert a ZenohId into a [u8; 16].
DariusIMP
force-pushed
the
feat/zenohid/fromslice
branch
from
492e908 to
3c14ad1
Compare
Mallets
reviewed
Sep 9, 2024
commons/zenoh-config/src/wrappers.rs
Outdated
| @@ -72,6 +81,13 @@ impl From<ZenohId> for OwnedKeyExpr { | |||
| } | |||
| } | |||
|
|
|||
| impl From<ZenohId> for [u8; ZenohIdProto::MAX_SIZE] { | |||
There was a problem hiding this comment.
Instead of this From it would be better to expose to_le_bytes which provides stronger guarantees on the endianess.
DariusIMP
changed the title
[u8; 16] & try from slice
DariusIMP
changed the title
[u8; 16] & try from slice[u8; 16] & to_le_bytes()
Mallets
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allowing users to create a ZenohId from a slice, using TryFrom, and also allowing users to convert a ZenohId into
[u8; 16].Related to eclipse-zenoh/zenoh-kotlin#196.