Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select links based on message Reliability #1356

Closed
wants to merge 13 commits into from

Conversation

fuzzypixelz
Copy link
Member

Depends on #1324.

@fuzzypixelz fuzzypixelz self-assigned this Sep 4, 2024
@fuzzypixelz fuzzypixelz added enhancement Existing things could work better new feature Something new is needed labels Sep 4, 2024
@eclipse-zenoh eclipse-zenoh deleted a comment from github-actions bot Sep 4, 2024
@fuzzypixelz fuzzypixelz marked this pull request as draft September 4, 2024 17:04
///
/// ## Endpoint metadata
///
/// **priorities**: a Rust-style half-open range (e.g. `2..4` signifies priorities 2 and 3).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The range should be inclusive. It doesn't make sense to express priorities=1..9 to set any priority from 1 to 8 given that priority 9 does not exist.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point!

@fuzzypixelz
Copy link
Member Author

Closed in favor of #1360.

@fuzzypixelz fuzzypixelz closed this Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Existing things could work better new feature Something new is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants