Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove subscriber reliability option #1353

Merged
merged 5 commits into from
Sep 11, 2024
Merged

Conversation

Mallets
Copy link
Member

@Mallets Mallets commented Sep 4, 2024

Linked issue #1348
To be merged after #1305

Copy link

github-actions bot commented Sep 4, 2024

PR missing one of the required labels: {'internal', 'breaking-change', 'bug', 'enhancement', 'documentation', 'new feature', 'dependencies'}

@Mallets Mallets added the breaking-change Indicates that the issue implies a breaking change (be it at compile time or at runtime) label Sep 4, 2024
@Mallets Mallets marked this pull request as ready for review September 5, 2024 07:07
@Mallets
Copy link
Member Author

Mallets commented Sep 5, 2024

This PR is ready to be merged in Rust.
However, it's safer to wait for all Zenoh bindings to implement #reliabilty option.
Once bindings are OK, this PR can finally be merged.

@Mallets Mallets merged commit 36b97aa into main Sep 11, 2024
23 of 24 checks passed
@Mallets Mallets deleted the dev/subscriber_reliability branch September 11, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change Indicates that the issue implies a breaking change (be it at compile time or at runtime)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants