Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve pipeline jitter #1335

Merged
merged 16 commits into from
Aug 28, 2024
Merged

Improve pipeline jitter #1335

merged 16 commits into from
Aug 28, 2024

Conversation

Mallets
Copy link
Member

@Mallets Mallets commented Aug 28, 2024

@Mallets Mallets marked this pull request as ready for review August 28, 2024 08:25
@Mallets Mallets requested a review from JEnoch August 28, 2024 08:25
@Mallets
Copy link
Member Author

Mallets commented Aug 28, 2024

@evshary could you help testing this PR?

@evshary
Copy link
Contributor

evshary commented Aug 28, 2024

@evshary could you help testing this PR?

Yes, it works smoothly on Carla bridge with the default config (batch is on)

commons/zenoh-sync/src/event.rs Outdated Show resolved Hide resolved
io/zenoh-transport/src/common/pipeline.rs Outdated Show resolved Hide resolved
@JEnoch
Copy link
Member

JEnoch commented Aug 28, 2024

Tested in the scope of eclipse-zenoh/zenoh-plugin-ros2dds#192 .
I confirm this PR solves the issue with default configuration (i.e. no longer need to configure the express flag as explained in this comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants