refactor(storage-manager): move prefix related functions in crate #1325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
J-Loudet
force-pushed
the
refactor/strip-prefix
branch
from
5914a89 to
54dc75b
Compare
This change is motivated by the refactor of the Replication feature. In order to exchange metadata that can be processed by all Replicas, the key expressions associated with the data stored must be prefixed (when sent) and stripped (when received). This commit exposes two functions, at the `zenoh-plugin-storage-manager` crate, that perform these operations. The objective is to reuse these functions in the Replication refactor and, as we intend to move the Replication in its own crate, exposing them at the crate level makes it easier to then import them. * plugins/zenoh-plugin-storage-manager/src/lib.rs: - moved there the `strip_prefix` function, - moved there the `get_prefixed` function and renamed it to `prefix`. * plugins/zenoh-plugin-storage-manager/src/replica/mod.rs: updated the call to the previously named `get_prefixed` function. * plugins/zenoh-plugin-storage-manager/src/replica/storage.rs: - removed the `strip_prefix` method, - removed the `prefix` function, - updated the call to `strip_prefix` and `get_prefixed`.
J-Loudet
force-pushed
the
refactor/strip-prefix
branch
from
54dc75b to
407e7ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is motivated by the refactor of the Replication feature. In order to exchange metadata that can be processed by all Replicas, the key expressions associated with the data stored must be prefixed (when sent) and stripped (when received).
This commit exposes two functions, at the
zenoh-plugin-storage-managercrate, that perform these operations.The objective is to reuse these functions in the Replication refactor and, as we intend to move the Replication in its own crate, exposing them at the crate level makes it easier to then import them.
strip_prefixfunction,get_prefixedfunction and renamed it toprefix.get_prefixedfunction.strip_prefixmethod,prefixfunction,strip_prefixandget_prefixed.