Support for IPv6-only network interfaces #1322
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to Socket::new() by calls to Domain::for_address(), so that the domain is inferred from the address. This is necessary for network interfaces that are IPv6 only.
|
Thanks @alexis-boisserand-acuity for the PR! |
|
@alexis-boisserand-acuity if you have issue to sign the ECA, another option to get your PR merged is that you state you are fine for us to include your changes in a PR we open. |
Mallets
approved these changes
Sep 2, 2024
|
I was on vacation. Thanks for merging these changes in your PR.
Envoyé à partir de Outlook pour Android<https://aka.ms/AAb9ysg>
…________________________________
From: Luca Cominardi ***@***.***>
Sent: Monday, September 2, 2024 10:49:20 AM
To: eclipse-zenoh/zenoh ***@***.***>
Cc: Boisserand, Alexis ***@***.***>; Mention ***@***.***>
Subject: Re: [eclipse-zenoh/zenoh] Support for IPv6-only network interfaces (PR #1322)
I've integrated your changes in #1345. Once you have signed the ECA I can revert #1345 and integrate this if needed. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned. Message
ZjQcmQRYFpfptBannerStart
This Message Is From an External Sender
This message came from outside your organization.
ZjQcmQRYFpfptBannerEnd
I've integrated your changes in #1345<https://urldefense.com/v3/__https://github.com/eclipse-zenoh/zenoh/pull/1345__;!!Po4YltK3bPMkYw!zdgDc69kQsy6GUGW1Dft3ViEGyl5kwfGBR3Z6cGqWBqcbetETP3NO-w73JGPbpOtg6mC6wcVY7R8PNDNwc8fr90zZT0a-O7gHQI$>.
Once you have signed the ECA I can revert #1345<https://urldefense.com/v3/__https://github.com/eclipse-zenoh/zenoh/pull/1345__;!!Po4YltK3bPMkYw!zdgDc69kQsy6GUGW1Dft3ViEGyl5kwfGBR3Z6cGqWBqcbetETP3NO-w73JGPbpOtg6mC6wcVY7R8PNDNwc8fr90zZT0a-O7gHQI$> and integrate this if needed.
—
Reply to this email directly, view it on GitHub<https://urldefense.com/v3/__https://github.com/eclipse-zenoh/zenoh/pull/1322*issuecomment-2324175660__;Iw!!Po4YltK3bPMkYw!zdgDc69kQsy6GUGW1Dft3ViEGyl5kwfGBR3Z6cGqWBqcbetETP3NO-w73JGPbpOtg6mC6wcVY7R8PNDNwc8fr90zZT0a06SuXDw$>, or unsubscribe<https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/BC423XNOJ2NSZYLSCWWZFYDZUQRBBAVCNFSM6AAAAABNASZ2X2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRUGE3TKNRWGA__;!!Po4YltK3bPMkYw!zdgDc69kQsy6GUGW1Dft3ViEGyl5kwfGBR3Z6cGqWBqcbetETP3NO-w73JGPbpOtg6mC6wcVY7R8PNDNwc8fr90zZT0aLim98gU$>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
Thanks again for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Substitutes the hardcoded Domain::IPV4 first parameter of some calls to Socket::new() by calls to Domain::for_address(), so that the domain is inferred from the address. This is necessary for network interfaces that are IPv6 only.
I ran into this issue while trying to run zenoh over thread, which is an IPv6 only technology.