Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: don't undeclare objects on drop #1295

Closed

Conversation

wyfo
Copy link
Contributor

@wyfo wyfo commented Aug 5, 2024

No description provided.

@wyfo wyfo force-pushed the background_default branch from 0185ed7 to b0171c5 Compare August 5, 2024 06:13
@wyfo
Copy link
Contributor Author

wyfo commented Aug 5, 2024

It was not possible to remove the internal pool of the session in zenoh-python, because publishers still need an Arc, not a Weak.

@wyfo wyfo force-pushed the background_default branch from b0171c5 to d16b23d Compare August 5, 2024 07:20
@wyfo wyfo force-pushed the background_default branch 4 times, most recently from 9302618 to 31ae676 Compare August 26, 2024 12:18
@wyfo wyfo force-pushed the background_default branch from 31ae676 to 1bd2700 Compare August 26, 2024 12:33
@wyfo wyfo marked this pull request as ready for review August 26, 2024 12:38
@wyfo
Copy link
Contributor Author

wyfo commented Aug 26, 2024

@Mallets @kydos

@wyfo
Copy link
Contributor Author

wyfo commented Aug 28, 2024

Closed in favor of #1334

@wyfo wyfo closed this Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant