Support bytes::Bytes for ZBytes #1248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ChenYing Kuo <[email protected]>
|
@Mallets Could you please help me review it? |
Mallets
approved these changes
Jul 22, 2024
evshary
commented
Jul 23, 2024
| // ZSlice resulting in zero-copy and zero-alloc bytes::Bytes serialization. | ||
| #[repr(transparent)] | ||
| #[derive(Debug)] | ||
| struct BytesWrap(bytes::Bytes); |
There was a problem hiding this comment.
I guess we use BytesWrap to wrap Bytes is to avoid the orphan rule, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since uProtocol UPayload is using bytes::Bytes, I think it will be good if we can support the transformation in ZBytes.