Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove clone from Publisher #1371

Closed
milyin opened this issue Sep 6, 2024 · 1 comment
Closed

remove clone from Publisher #1371

milyin opened this issue Sep 6, 2024 · 1 comment
Labels
api fix Correct API enhancement Existing things could work better release Part of the next release

Comments

@milyin
Copy link
Contributor

milyin commented Sep 6, 2024

Describe the release item

when publisher is undeclared, it's clones ceases to work too. This may be unexpected and confusing for user. So better not to provide clone on undeclareable objects. User always can wrap it to Arc<Mutex<...>> if necessary
@milyin milyin added the release Part of the next release label Sep 6, 2024
@milyin milyin added enhancement Existing things could work better api fix Correct API labels Sep 6, 2024
@milyin milyin mentioned this issue Sep 6, 2024
Closed
12 tasks
@wyfo
Copy link
Contributor

wyfo commented Sep 9, 2024

Already done in #1370

@milyin milyin closed this as not planned Won't fix, can't repro, duplicate, stale Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api fix Correct API enhancement Existing things could work better release Part of the next release
Projects
Zenoh 1.0.0 release
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@milyin @wyfo