Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

align clone methods: coordination task #1372

Closed
8 of 12 tasks
milyin opened this issue Sep 6, 2024 · 1 comment
Closed
8 of 12 tasks

align clone methods: coordination task #1372

milyin opened this issue Sep 6, 2024 · 1 comment
Assignees
Labels
api fix Correct API enhancement Existing things could work better umbrella The task which covers multiple other tasks

Comments

@milyin
Copy link
Contributor

milyin commented Sep 6, 2024

Describe the release item

after the discussion on eclipse-zenoh/zenoh-c#549 issue the following approach for clone implementation was proposed

zenoh-c and zenoh-pico should pass mutable z_loaned_xxx_t* parameter to callback and should provide z_take operation for taking value from such mutable loaned reference. This allows user to either take ownership of passed value or keep it for caller. Now this is achieved by cloning const z_loaned_xxx_t* object.

This task can be split into 2 parts, it's enough to implement only first one for 1.0.0 release

@milyin
Copy link
Contributor Author

milyin commented Dec 3, 2024

Closing the issue, the "take_from_mutable" eclipse-zenoh/zenoh-c#718 remains open, no need to covet it here anymore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api fix Correct API enhancement Existing things could work better umbrella The task which covers multiple other tasks
Projects
Status: Done
Development

No branches or pull requests

2 participants