fix: getting reference instead of value in PluginsManager::declare_st…

…atic_plugin Signed-off-by: Gabriele Baldoni <[email protected]>
eclipse-zenoh · Sep 13, 2024 · e12b3a0 · e12b3a0
1 parent aa1f703
commit e12b3a0
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/plugins/zenoh-plugin-storage-manager/src/lib.rs b/plugins/zenoh-plugin-storage-manager/src/lib.rs
@@ -126,9 +126,8 @@ impl StorageRuntimeInner {
         } = config;
         let lib_loader = LibLoader::new(backend_search_dirs);
 
-        let plugins_manager =
-            PluginsManager::dynamic(lib_loader.clone(), BACKEND_LIB_PREFIX)
-                .declare_static_plugin::<MemoryBackend, &str>(MEMORY_BACKEND_NAME, true);
+        let mut plugins_manager = PluginsManager::dynamic(lib_loader.clone(), BACKEND_LIB_PREFIX);
+        plugins_manager.declare_static_plugin::<MemoryBackend, &str>(MEMORY_BACKEND_NAME, true);
 
         let session = Arc::new(zenoh::session::init(runtime.clone()).wait()?);
 

diff --git a/plugins/zenoh-plugin-trait/src/manager.rs b/plugins/zenoh-plugin-trait/src/manager.rs
@@ -132,10 +132,10 @@ impl<StartArgs: PluginStartArgs + 'static, Instance: PluginInstance + 'static>
         P: Plugin<StartArgs = StartArgs, Instance = Instance> + Send + Sync,
         S: Into<String>,
     >(
-        mut self,
+        &mut self,
         id: S,
         required: bool,
-    ) -> Self {
+    ) {
         let id = id.into();
         let plugin_loader: StaticPlugin<StartArgs, Instance, P> =
             StaticPlugin::new(id.clone(), required);
@@ -152,7 +152,6 @@ impl<StartArgs: PluginStartArgs + 'static, Instance: PluginInstance + 'static>
             self.plugins.last().unwrap().id(),
             self.plugins.last().unwrap().name()
         );
-        self
     }
 
     /// Add dynamic plugin to the manager by name, automatically prepending the default library prefix