Do not send sub declarations to multicast on windows

eclipse-zenoh · Sep 8, 2023 · d0f08e8 · d0f08e8
1 parent 62d0f8e
commit d0f08e8
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/zenoh/src/net/routing/pubsub.rs b/zenoh/src/net/routing/pubsub.rs
@@ -464,6 +464,9 @@ pub fn declare_client_subscription(
                         );
                     } else {
                         propagate_simple_subscription(&mut wtables, &res, &propa_sub_info, face);
+                        // This introduced a buffer overflow on windows
+                        // TODO: Let's deactivate this on windows until Fixed
+                        #[cfg(not(windows))]
                         for mcast_group in &wtables.mcast_groups {
                             mcast_group.primitives.send_declare(Declare {
                                 ext_qos: ext::QoSType::default(),
@@ -480,6 +483,9 @@ pub fn declare_client_subscription(
                 }
                 _ => {
                     propagate_simple_subscription(&mut wtables, &res, &propa_sub_info, face);
+                    // This introduced a buffer overflow on windows
+                    // TODO: Let's deactivate this on windows until Fixed
+                    #[cfg(not(windows))]
                     for mcast_group in &wtables.mcast_groups {
                         mcast_group.primitives.send_declare(Declare {
                             ext_qos: ext::QoSType::default(),