Skip to content

Commit

Permalink
fix: update release workflow to depend on cargo (#1410)
Browse files Browse the repository at this point in the history
Makes all the publishing steps depend on cargo publishing. This way if
there's a failure publishing to crates.io, we don't publish to
github/docker/debian/homebrew, making it easier to retract the release.
  • Loading branch information
diogomatsubara authored Sep 13, 2024
1 parent aa1f703 commit c1bb79d
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ jobs:

debian:
name: Publish Debian packages
needs: [tag, build-debian]
needs: [tag, build-debian, cargo]
uses: eclipse-zenoh/ci/.github/workflows/release-crates-debian.yml@main
with:
no-build: true
Expand All @@ -107,7 +107,7 @@ jobs:

homebrew:
name: Publish Homebrew formulae
needs: [tag, build-standalone]
needs: [tag, build-standalone, cargo]
uses: eclipse-zenoh/ci/.github/workflows/release-crates-homebrew.yml@main
with:
no-build: true
Expand All @@ -128,7 +128,7 @@ jobs:

eclipse:
name: Publish artifacts to Eclipse downloads
needs: [tag, build-standalone]
needs: [tag, build-standalone, cargo]
uses: eclipse-zenoh/ci/.github/workflows/release-crates-eclipse.yml@main
with:
no-build: true
Expand All @@ -145,7 +145,7 @@ jobs:

github:
name: Publish artifacts to GitHub Releases
needs: [tag, build-standalone]
needs: [tag, build-standalone, cargo]
uses: eclipse-zenoh/ci/.github/workflows/release-crates-github.yml@main
with:
no-build: true
Expand All @@ -161,7 +161,7 @@ jobs:

dockerhub:
name: Publish container image to DockerHub
needs: [tag, build-standalone]
needs: [tag, build-standalone, cargo]
uses: eclipse-zenoh/ci/.github/workflows/release-crates-dockerhub.yml@main
with:
no-build: true
Expand Down

0 comments on commit c1bb79d

Please sign in to comment.