Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

example chat application which uses zenoh-ts #72

Merged
merged 50 commits into from
Dec 17, 2024
Merged

Conversation

milyin
Copy link
Contributor

@milyin milyin commented Dec 13, 2024

  • added example application for demonstrating real zenoh-ts usage
  • corrected zenoh-ts to allow it to be executed in the browser directly, without additional bundling

milyin added 30 commits December 2, 2024 21:14
Copy link

PR missing one of the required labels: {'documentation', 'enhancement', 'breaking-change', 'internal', 'dependencies', 'bug', 'new feature'}

Copy link

PR missing one of the required labels: {'new feature', 'enhancement', 'internal', 'documentation', 'bug', 'breaking-change', 'dependencies'}

Copy link

PR missing one of the required labels: {'enhancement', 'breaking-change', 'new feature', 'internal', 'documentation', 'dependencies', 'bug'}

@milyin milyin added documentation Improvements or additions to documentation enhancement New feature or request labels Dec 13, 2024
zenoh-ts/examples/chat/README.md Outdated Show resolved Hide resolved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may make sense to add this validation of key expressions directly in the zenoh-ts library.
Currently the library does not do any validation of Key Expressions on the client side.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this piece of code is just preparation for further implenmentinng this functionality in the library itself

@milyin milyin merged commit a4b1270 into main Dec 17, 2024
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants